Issue with the built-in functions (such as if(), floor() ) in COMSOL

Posted Nov 22, 2023, 7:30 a.m. EST Battery Design Version 6.1 2 Replies

Shantanu Sontakke

Send Private Message Flag post as spam

Please login with a confirmed email address before reporting spam

I am facing an issue while running the Charge-Discharge Cycling simulation in Lithium-Ion Battery Interface. For the context, there are some variables (cycle_no, t_factor, corr_factor1_) defined in the "Definitions" node under the "comp1" node with the expression mentioned as follows. Also, a required interpolation function ("t_factor_int") is defined earlier in the global definitions.

t_factor = t_factor_int(comp1.liion.cdc1.cycle_counter)

corr_factor1_ = if(t_factor==1,1,0)

cycle_no = if(comp1.liion.cdc1.cycle_counter<3,comp1.liion.cdc1.cycle_countert_factor,(comp1.liion.cdc1.cycle_counter-floor(comp1.liion.cdc1.cycle_counter/3))250+corr_factor1_)

For the current battery cycling study, I need to supply charge and discharge current as a function of cycle number in the Charge-Discharge Cycling boundary condition, which are defined as:

Discharge Current = if((cycle_no==0)+(mod(cycle_no,10)==1),-i_1C/3,-i_1C); Charge Current = i_1C

(i_1C is the 1C current value defined earlier in the global definitions)

After running the simulations for some cycles, the following issues arise.

Issue with the if() function: The if() function in the "corr_factor1_" variables is not updated as expected i.e., does not give value as 1 if "t_factor" is 1.

Issue with the floor() function: The floor() function too does not work as expected. For example, while calculating "floor(liion.cdc1.cycle_counter/3)", the output obtained for floor(39/3) is 12 instead of 13.

The aforementioned issues continue for further cycles although they weren't observed during the earlier cycles of the same run.

Reply

2 Replies Last Post Nov 23, 2023, 2:29 a.m. EST

Magnus Ringh COMSOL Employee

Please login with a confirmed email address before reporting spam

Posted: 5 months ago

Hi Shantanu,

I don't know your entire model setup, but I think it can be better to not do exact comparisons to 1 and 0 when you are dealing with numerical simulations using floating-point numbers. Some numerical noise might make such comparisons return false, since the value that you compare to 1 isn't exactly 1 but 1 plus or minus a few "eps" (the machine precision number). Instead of t_factor==1 you might use abs(tfactor-1)<100*eps or something similar. For the floor case, floor(round(liion.cdc1.cycle_counter)/3) might be more robust.

Best regards,

Magnus

Shantanu Sontakke

Send Private Message Flag post as spam

Please login with a confirmed email address before reporting spam

Posted: 5 months ago

Hi Shantanu,

I don't know your entire model setup, but I think it can be better to not do exact comparisons to 1 and 0 when you are dealing with numerical simulations using floating-point numbers. Some numerical noise might make such comparisons return false, since the value that you compare to 1 isn't exactly 1 but 1 plus or minus a few "eps" (the machine precision number). Instead of t_factor==1 you might use `abs(tfactor-1)

Hi Magnus,

Thanks for a quick reply. The floor() function issue was resolved by the change you suggested using round() in its expression. As for the if() function, it worked by using the round() function if(round(t_factor)==1,1,0).

As you suggested, the issue was the floating point error as the value of t_factor may have been 0.99999... so the if() expression returned false.

Thanks and Regards, Shantanu

Reply

Please read the discussion forum rules before posting.

Discussion Forum Rules and Guidelines

The goal of COMSOL Access is to provide a forum for you to communicate effectively with COMSOL as well as your colleagues within the multiphysics simulation community. This involves providing you with access to technical support and downloads of the latest {:comsol} software releases, as well as the ability to share your comments and work with other users of the {:comsol} software through forums such as the blog, discussion forum, and Application Exchange. In order to make this an efficient and pleasant experience for you and other members of COMSOL Access, we ask that you follow a few rules and guidelines.

When registering for COMSOL Access, you agree to provide your complete and truthful information for all fields requested on your COMSOL Access account registration page. You also agree to maintain the accuracy of all information associated with you on your COMSOL Access account. You agree to maintain your COMSOL Access account for use solely by you, not to share your username and password with anyone else, and to take appropriate precautions to restrict access to your username and password from others. Furthermore, you agree not to submit any information relating to your employer through your COMSOL Access account without your employer’s authorization. Should you use a COMSOL Access account associated with an employer, you agree to immediately discontinue using that account upon termination of that employment.

The moderators of the forums will remove any generally objectionable material as quickly as possible. You acknowledge that all posts made to these forums express the views and opinions of the author and not the administrators, moderators, or webmaster (except for posts by these people). Hence, they will not be held liable.

You agree not to post or link to any material that is abusive, obscene, vulgar, slanderous, hateful, threatening, sexually oriented, or that infringes upon or violates any third-party rights or any other material that may violate any applicable laws. You agree that you will not otherwise use your COMSOL Access account to violate or to assist anyone in violating any law. Engaging in any activity in violation of these COMSOL Access rules and guidelines may lead to you being immediately and permanently banned from COMSOL Access. The IP address of all posts is recorded to aid in enforcing these conditions. You agree that the webmaster, administrator, and moderators of the forums have the right to remove, move, or close any topic at any time as they see fit. As a user of COMSOL Access, you agree to any information you have entered into any of the forums being stored in a database.

You agree that you will not use your COMSOL Access account in violation of any applicable export control laws. You represent and warrant that you are not subject to any comprehensive sanction or embargo by the U.S. or any other country, nor are you identified on any list maintained by the U.S. government that identifies persons for which the U.S. maintains restrictions. Further, you represent and warrant that you are not subject to any restriction on the receipt of technology or products under the export control laws of the U.S. or any other country.

Basic Rules

Flaming: Do not post any messages that harass, insult, belittle, threaten, or flame another member or guest. Debates are fine, but argue with the point, not the person.
Trolling: Do not post with the purpose of starting a dispute. Note that a person disagreeing with your opinion is not considered trolling; keep it civil, even if you are sure that the other person is wrong. Anything seen as trolling will result in you being banned.
Spamming: Posts without content or containing nonsense waste space and everyone's time. Spam will be removed from the forum.
Offensive Posts, Links or Images: Do not use profanity, racial, ethnic, religious, or other slurs or any other offensive material.
Advertising: Posting of advertisements for products or services, links to auctions, affiliate links, links to promote websites, and so forth is not allowed.
Disclosure of Personal Information: Do not disclose any other member's email, real name, address, phone number, IP address, or other personal information. This includes posting contents of emails and private messages without the sender's consent. Do not bring personal disputes into the forums. Bans and warnings issued to other users are considered personal information.
Misleading Titles: The subject line of the post should be as informative as possible about the content of the post. This also reduces the amount of duplicate posts.
Thread Hijacking: Taking a thread off-topic to pursue one's own agenda is not permitted.
Piracy: Do not upload, post, email, transmit, or otherwise make available any content that infringes upon any patent, trademark, trade secret, copyright, or other proprietary rights ("Rights") of any party. This includes COMSOL model files created by a forged or illegitimate license.
Honesty: Users must provide truthful information in creating their COMSOL Access account.

These rules are subject to change. The moderators reserve the right to remove, edit, or move posts at their discretion. The COMSOL Access administrators will reserve the right to permanently remove a user account without notice if any of the rules are not followed. Particular services accessible with your COMSOL Access account may be subject to additional rules. You agree to comply with all rules applicable to each service you access through your COMSOL Access account.

Posting Guidelines

When posting, understand that you are trying to communicate with other people. Although many COMSOL Access members are not fluent in English, the official language of this forum is English.

Here are some important guidelines of language:

Write in English.
If you are familiar with LaTeX, please use this to write mathematical equations.
Always do a quick check for spelling/grammar mistakes.
Format your post in a legible manner. Use the Preview button often.
Be concise and articulate as much as possible.
Use the Enter key to create paragraphs.
Capitalize correctly. It is difficult to read posts that are written entirely in uppercase or lowercase.
Use correct punctuation. Avoid run-on sentences.
Try to avoid using “text speak”, “net speak”, or slang. The purpose of language is to be understood.
Never invent acronyms and use as few acronyms as possible. For example, write "COMSOL Multiphysics" and not "CMP".
Review your post before publishing it. Try to catch typos.
Please check to see if a topic has already been posted. Do not post multiple threads on the same topic.

Disclaimer

By submitting content to the forums, you hereby grant COMSOL a nonexclusive, royalty-free, perpetual, worldwide, and unrestricted license to reproduce, publicly display, publicly distribute, and prepare derivative works of the content. COMSOL hereby grants you a license to copy and/or use content from the forums solely for your own internal purposes. COMSOL provides the forum service for the benefit of our users to share content with the community. All content is provided "as is" without warranty of any kind, express or implied, including without limitation, warranties of merchantability, noninfringement, design, operation, and fitness for a particular purpose, and the entire risk as to the quality and performance of the programs is with you.

Neither COMSOL, the authors, nor the copyright owners of submitted materials warrant that the programs will be error-free, uninterrupted, virus-free, secure, and suitable for your needs, produce specific results, or that errors or failures will be corrected. Comments on supplied content should be sent to the author or copyright owner through the tools provided in the forums.

Please log in to post a reply.

Discussion Forum